The fallback overload could not infer `R` from the handlers: `R` appeared only inside the `Exact` constraint, which is not an inference site, so with inferred handler params it collapsed to `unknown` and the matcher silently returned `UnaryFn<T, unknown>`. Adding `Partial<Handlers<T, R>>` to the handler parameter gives `R` an inference site, so the common return is inferred from the handlers and the fallback alike. Tests drop their explicit handler return annotations: real handlers are short and unannotated, and the common type is now inferred from them.
419 lines
13 KiB
TypeScript
419 lines
13 KiB
TypeScript
/* oxlint-disable typescript/no-floating-promises -- expectTypeOf() is a sync type-assertion library that the type-aware linter misidentifies as a promise */
|
|
import { strict as assert } from "node:assert";
|
|
import path from "node:path";
|
|
import { test } from "node:test";
|
|
|
|
import { expectTypeOf } from "expect-type";
|
|
|
|
import {
|
|
type CompletionTarget,
|
|
LspSession,
|
|
} from "#test-utils/lsp-completion.ts";
|
|
|
|
import { getMatcher, getMatcherW } from "./primitive.ts";
|
|
|
|
// ============================================================================
|
|
// API: getMatcher — ✔️ Exhaustive / ✔️ ReturnsStrict
|
|
// ============================================================================
|
|
|
|
test("getMatcher: exhaustive pattern infers one common return type", () => {
|
|
// Arrange
|
|
const factory = getMatcher<"a" | "b">();
|
|
|
|
// Act
|
|
const matcher = factory({
|
|
a: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"a">();
|
|
return 1;
|
|
},
|
|
b: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"b">();
|
|
return 2;
|
|
},
|
|
});
|
|
|
|
// Assert
|
|
// ✔️ ReturnsStrict: R is the best common return type, not a widening union.
|
|
expectTypeOf(matcher).toEqualTypeOf<(shape: "a" | "b") => number>();
|
|
// ❌ a value outside T must not be accepted by the matcher
|
|
expectTypeOf<"c">().not.toExtend<Parameters<typeof matcher>[0]>();
|
|
assert.equal(matcher("a"), 1);
|
|
assert.equal(matcher("b"), 2);
|
|
});
|
|
|
|
test("getMatcher: dispatches on numeric literal keys", () => {
|
|
// Arrange
|
|
const factory = getMatcher<1 | 2>();
|
|
|
|
// Act
|
|
const matcher = factory({
|
|
1: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<1>();
|
|
return n + 1;
|
|
},
|
|
2: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<2>();
|
|
return n * 10;
|
|
},
|
|
});
|
|
|
|
// Assert
|
|
expectTypeOf(matcher).toEqualTypeOf<(shape: 1 | 2) => number>();
|
|
assert.equal(matcher(1), 2);
|
|
assert.equal(matcher(2), 20);
|
|
});
|
|
|
|
test("getMatcher: dispatches on mixed string and numeric keys", () => {
|
|
// Arrange
|
|
const factory = getMatcher<"a" | "b" | 1 | 2>();
|
|
|
|
// Act
|
|
const matcher = factory({
|
|
a: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"a">();
|
|
return 1;
|
|
},
|
|
b: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"b">();
|
|
return 2;
|
|
},
|
|
1: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<1>();
|
|
return 10;
|
|
},
|
|
2: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<2>();
|
|
return 20;
|
|
},
|
|
});
|
|
|
|
// Assert
|
|
expectTypeOf(matcher).toEqualTypeOf<(shape: "a" | "b" | 1 | 2) => number>();
|
|
assert.equal(matcher("a"), 1);
|
|
assert.equal(matcher("b"), 2);
|
|
assert.equal(matcher(1), 10);
|
|
assert.equal(matcher(2), 20);
|
|
});
|
|
|
|
// ============================================================================
|
|
// API: getMatcher — ❌ Exhaustive (fallback) / ✔️ ReturnsStrict
|
|
// ============================================================================
|
|
|
|
test("getMatcher: a `_` fallback receives the unhandled keys", () => {
|
|
// Arrange
|
|
const factory = getMatcher<"a" | "b" | "c">();
|
|
|
|
// Act
|
|
const matcher = factory(
|
|
{
|
|
a: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"a">();
|
|
return 1 as const;
|
|
},
|
|
},
|
|
(s) => {
|
|
// The fallback sees only the keys `a` did not handle.
|
|
expectTypeOf(s).toEqualTypeOf<"b" | "c">();
|
|
return 2 as const;
|
|
},
|
|
);
|
|
|
|
// Assert
|
|
expectTypeOf(matcher).toEqualTypeOf<(shape: "a" | "b" | "c") => 1 | 2>();
|
|
// ❌ a value outside T must not be accepted by the matcher
|
|
expectTypeOf<"d">().not.toExtend<Parameters<typeof matcher>[0]>();
|
|
assert.equal(matcher("a"), 1);
|
|
assert.equal(matcher("b"), 2);
|
|
assert.equal(matcher("c"), 2);
|
|
});
|
|
|
|
test("getMatcher: a `_` fallback routes mixed string and numeric gaps", () => {
|
|
// Arrange
|
|
const factory = getMatcher<"a" | "b" | 1 | 2>();
|
|
|
|
// Act
|
|
const matcher = factory(
|
|
{
|
|
a: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"a">();
|
|
return "A";
|
|
},
|
|
1: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<1>();
|
|
return "one";
|
|
},
|
|
},
|
|
(s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"b" | 2>();
|
|
return "fallback";
|
|
},
|
|
);
|
|
|
|
// Assert
|
|
expectTypeOf(matcher).toEqualTypeOf<(shape: "a" | "b" | 1 | 2) => string>();
|
|
assert.equal(matcher("a"), "A");
|
|
assert.equal(matcher("b"), "fallback");
|
|
assert.equal(matcher(1), "one");
|
|
assert.equal(matcher(2), "fallback");
|
|
});
|
|
|
|
// ============================================================================
|
|
// API: getMatcherW — ✔️ Exhaustive / ❌ ReturnsStrict
|
|
// ============================================================================
|
|
|
|
test("getMatcherW: exhaustive pattern widens to the union of handler returns", () => {
|
|
// Arrange
|
|
const factory = getMatcherW<"x" | "y">();
|
|
|
|
// Act
|
|
const matcher = factory({
|
|
x: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"x">();
|
|
return 1 as const;
|
|
},
|
|
y: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"y">();
|
|
return "two" as const;
|
|
},
|
|
});
|
|
|
|
// Assert
|
|
// ❌ ReturnsStrict: mixed handler returns widen to their union.
|
|
expectTypeOf(matcher).toEqualTypeOf<(shape: "x" | "y") => 1 | "two">();
|
|
// ❌ a value outside T must not be accepted by the matcher
|
|
expectTypeOf<"z">().not.toExtend<Parameters<typeof matcher>[0]>();
|
|
assert.equal(matcher("x"), 1);
|
|
assert.equal(matcher("y"), "two");
|
|
});
|
|
|
|
test("getMatcherW: dispatches on mixed string and numeric keys", () => {
|
|
// Arrange
|
|
const factory = getMatcherW<"a" | "b" | 1 | 2>();
|
|
|
|
// Act
|
|
const matcher = factory({
|
|
a: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"a">();
|
|
return "A" as const;
|
|
},
|
|
b: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"b">();
|
|
return "B" as const;
|
|
},
|
|
1: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<1>();
|
|
return 10 as const;
|
|
},
|
|
2: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<2>();
|
|
return 20 as const;
|
|
},
|
|
});
|
|
|
|
// Assert
|
|
expectTypeOf(matcher).toEqualTypeOf<
|
|
(shape: "a" | "b" | 1 | 2) => "A" | "B" | 10 | 20
|
|
>();
|
|
assert.equal(matcher("a"), "A");
|
|
assert.equal(matcher("b"), "B");
|
|
assert.equal(matcher(1), 10);
|
|
assert.equal(matcher(2), 20);
|
|
});
|
|
|
|
// ============================================================================
|
|
// API: getMatcherW — ❌ Exhaustive (fallback) / ❌ ReturnsStrict
|
|
// ============================================================================
|
|
|
|
test("getMatcherW: a `_` fallback widens gaps into the union", () => {
|
|
// Arrange
|
|
const factory = getMatcherW<"x" | "y" | "z">();
|
|
|
|
// Act
|
|
const matcher = factory(
|
|
{
|
|
x: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"x">();
|
|
return 1 as const;
|
|
},
|
|
},
|
|
(s) => {
|
|
// The fallback sees only the keys `x` did not handle.
|
|
expectTypeOf(s).toEqualTypeOf<"y" | "z">();
|
|
return "fallback" as const;
|
|
},
|
|
);
|
|
|
|
// Assert
|
|
expectTypeOf(matcher).toEqualTypeOf<
|
|
(shape: "x" | "y" | "z") => 1 | "fallback"
|
|
>();
|
|
// ❌ a value outside T must not be accepted by the matcher
|
|
expectTypeOf<"w">().not.toExtend<Parameters<typeof matcher>[0]>();
|
|
assert.equal(matcher("x"), 1);
|
|
assert.equal(matcher("y"), "fallback");
|
|
assert.equal(matcher("z"), "fallback");
|
|
});
|
|
|
|
test("getMatcherW: a `_` fallback widens mixed string and numeric returns", () => {
|
|
// Arrange
|
|
const factory = getMatcherW<"a" | "b" | 1 | 2>();
|
|
|
|
// Act
|
|
const matcher = factory(
|
|
{
|
|
a: (s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"a">();
|
|
return "A" as const;
|
|
},
|
|
1: (n) => {
|
|
expectTypeOf(n).toEqualTypeOf<1>();
|
|
return 10 as const;
|
|
},
|
|
},
|
|
(s) => {
|
|
expectTypeOf(s).toEqualTypeOf<"b" | 2>();
|
|
return "fallback" as const;
|
|
},
|
|
);
|
|
|
|
// Assert
|
|
// ❌ ReturnsStrict: mixed handler returns widen to their union.
|
|
expectTypeOf(matcher).toEqualTypeOf<
|
|
(shape: "a" | "b" | 1 | 2) => "A" | 10 | "fallback"
|
|
>();
|
|
assert.equal(matcher("a"), "A");
|
|
assert.equal(matcher("b"), "fallback");
|
|
assert.equal(matcher(1), 10);
|
|
assert.equal(matcher(2), "fallback");
|
|
});
|
|
|
|
// ============================================================================
|
|
// Factory contracts — calls that must not compile
|
|
// ============================================================================
|
|
|
|
test("getMatcher factory rejects patterns outside its contract", () => {
|
|
// Arrange
|
|
const factory = getMatcher<"a" | "b">();
|
|
|
|
// Act / Assert — the calls below must not compile.
|
|
// `Parameters<typeof factory>[0]` resolves only the *last* overload, so it
|
|
// is not a sound "rejected" oracle (an accepted partial pattern does not
|
|
// extend it either); the call sites are the oracle instead.
|
|
factory({
|
|
a: () => 1,
|
|
b: () => 2,
|
|
// @ts-expect-error `c` is not part of the universe `"a" | "b"`
|
|
c: () => 3,
|
|
});
|
|
// @ts-expect-error a gap without a `_` fallback is not exhaustive
|
|
factory({ a: () => 1 });
|
|
});
|
|
|
|
test("getMatcherW factory rejects patterns outside its contract", () => {
|
|
// Arrange
|
|
const factory = getMatcherW<"x" | "y">();
|
|
|
|
// Act / Assert — the calls below must not compile
|
|
factory({
|
|
x: () => 1 as const,
|
|
y: () => 2 as const,
|
|
// @ts-expect-error `z` is not part of the universe `"x" | "y"`
|
|
z: () => 3 as const,
|
|
});
|
|
// @ts-expect-error a gap without a `_` fallback is not exhaustive
|
|
factory({ x: () => 1 as const });
|
|
});
|
|
|
|
// ============================================================================
|
|
// Autocomplete — the language server is the oracle, not the type system
|
|
// ============================================================================
|
|
|
|
// Completion is a contextual-type property that the type system cannot observe,
|
|
// so the cases below read the popup from the repo's language server (via the
|
|
// test helper) rather than pairing `expectTypeOf` with `assert` — see
|
|
// development/testing.md § Autocomplete. They probe the *matcher's* overloads,
|
|
// which is why they live with the matcher and not with the helper.
|
|
const REPO_ROOT = path.resolve(import.meta.dirname, "..");
|
|
const UNIVERSE = `"a" | "b" | "c"`;
|
|
|
|
// One session per probe: the tests share no language-server state (open
|
|
// documents, project membership), so they pass in any order.
|
|
interface LabelsProbe {
|
|
readonly name: string;
|
|
readonly factory: "getMatcher" | "getMatcherW";
|
|
readonly body: string;
|
|
}
|
|
|
|
const labelsFor = ({
|
|
name,
|
|
factory,
|
|
body,
|
|
}: LabelsProbe): Promise<readonly string[]> => {
|
|
const session = new LspSession(REPO_ROOT);
|
|
const target: CompletionTarget = {
|
|
file: `src/__autocomplete_${name}.ts`,
|
|
source: [
|
|
`import { ${factory} } from "./index.ts";`,
|
|
`const m = ${factory}<${UNIVERSE}>()({`,
|
|
body,
|
|
"});",
|
|
"",
|
|
].join("\n"),
|
|
};
|
|
return session
|
|
.completionLabelsAt(target)
|
|
.then((result) => result.labels)
|
|
.finally(() => session.close());
|
|
};
|
|
|
|
test("autocomplete: an exhaustive pattern requires the universe", () => {
|
|
// Arrange
|
|
const name = "getMatcher_fresh";
|
|
|
|
// Act
|
|
const labels = labelsFor({
|
|
name,
|
|
factory: "getMatcher",
|
|
body: " /*COMPLETE*/",
|
|
});
|
|
|
|
// Assert
|
|
return labels.then((result) => {
|
|
assert.deepEqual([...result], ["a", "b", "c"]);
|
|
});
|
|
});
|
|
|
|
test("autocomplete: handled keys drop out of the popup", () => {
|
|
// Arrange
|
|
const name = "getMatcher_after_key";
|
|
|
|
// Act
|
|
const labels = labelsFor({
|
|
name,
|
|
factory: "getMatcher",
|
|
body: " a: () => 1,\n /*COMPLETE*/",
|
|
});
|
|
|
|
// Assert
|
|
return labels.then((result) => {
|
|
assert.deepEqual([...result], ["b", "c"]);
|
|
});
|
|
});
|
|
|
|
test("autocomplete: `getMatcherW` offers the same popup as `getMatcher`", () => {
|
|
// Arrange
|
|
const name = "getMatcherW_fresh";
|
|
|
|
// Act
|
|
const labels = labelsFor({
|
|
name,
|
|
factory: "getMatcherW",
|
|
body: " /*COMPLETE*/",
|
|
});
|
|
|
|
// Assert
|
|
return labels.then((result) => {
|
|
assert.deepEqual([...result], ["a", "b", "c"]);
|
|
});
|
|
});
|