♻️ Replace verify skill with an npm verify script
A skill duplicated AGENTS.md policy and only worked in Agent-Skills harnesses. A bare top-level script is the repo-native affordance: every harness (and CI, and a human) reads package.json#scripts as the source of truth. Add `npm run verify` = `npm run check` + `test:unit` (tsc runs once, since check already type-checks) as the one-shot whole-project correctness gate. Delete .agents/skills/verify/SKILL.md. Document verify in README (Development + a Tooling-decisions bullet + bare-command note in the prefix list), CONTRIBUTING (feedback-tier table, "Before pushing", the bare-command paragraph, a "why these splits" bullet), and AGENTS.md (test = fast iterating gate, verify = definition of done; skill pointer removed).
This commit is contained in:
1 parent
3d0fe18d6a
commit
da5ab79f9b
5 files changed
+14
-49
No files matched your search
@@ -8,20 +8,16 @@ first-action facts. Do not restate evolving prose here — it will drift.
|
||||
## First action
|
||||
|
||||
- Project: F#-style pattern matching for TypeScript/ESM. Node `>=26` (pinned via `.node-version`), ESM-only (no CommonJS shim).
|
||||
- **Mandatory while iterating:** `npm run test` (runs `check:tsc`, then the unit suite). This is the gate you are responsible for.
|
||||
- **While iterating:** `npm run test` (`check:tsc` + the unit suite) for fast feedback on the files you changed.
|
||||
- **Definition of done — run this before you call the work finished:** `npm run verify`. It is one shot of the whole-project correctness ladder (`npm run check`: `tsc → oxlint → oxfmt → cspell`, then the unit suite; tsc runs once), excluding advisory maintenance. If all green, commit. If red, look at the output, fix the root cause, and re-run.
|
||||
- **On commit:** write a good message (see [CONTRIBUTING.md § Commit messages](./CONTRIBUTING.md#commit-messages)). Lefthook's pre-commit hook already runs the fast, offline, staged-file checks (`tsc` + `oxlint` + `oxfmt` + `cspell`) — don't run them by hand. If the hook fails on style, `npm run fix`, restage, recommit.
|
||||
- **Optional final gate:** `npm run check` (the fast, offline, whole-project correctness ladder: `tsc → oxlint → oxfmt → cspell`). Safe to run whenever you want a project-wide confirmation; pre-commit already covers staged files.
|
||||
- **`npm run maintain` is NOT part of the feature loop.** `maintain:knip` (dead-code/deps) and `maintain:outdated` (registry) are advisory maintenance scans. Run them only on an explicit maintenance / update-deps branch; CI surfaces them via a non-blocking job, never as a gate.
|
||||
|
||||
```sh
|
||||
npm run test # mandatory gate
|
||||
npm run check # optional project-wide confirmation
|
||||
npm run test # while iterating (fast feedback)
|
||||
npm run verify # definition of done: whole-project correctness, one shot
|
||||
```
|
||||
|
||||
The bot's definition of done: `npm run test` green, commit normally after.
|
||||
|
||||
- A project skill wraps this loop as an on-demand procedure: `/skill:verify` → [`.agents/skills/verify/SKILL.md`](./.agents/skills/verify/SKILL.md).
|
||||
|
||||
## Never do
|
||||
|
||||
Don't silence the type system to force a green run. As an agent these are forbidden:
|
||||
|
||||
Reference in new issue
Block a user