📝 Keep verify free of the emit path
verify is the local quick source-correctness check; the emit path is already gated by CI's build job, so adding build to verify would only add inner-loop friction for something CI covers.
This commit is contained in:
1 parent
0ceb5a586e
commit
b18e03ff97
1 file changed
+2
-2
+2
-2
@@ -13,10 +13,10 @@ Setup:
|
||||
- the README insists `@spences10/pi-lsp` is "pinned to 0.0.46", but the lockfile that pins the transitive tree does not survive a fresh clone
|
||||
☐ Commit `.pi/npm/package.json` + `package-lock.json` (recommended: treat it as a dev-environment lockfile, same class as the root one)
|
||||
☐ Or document that pi self-installs the extension and the pin is advisory — decide which
|
||||
☐ Gate the emit path in `npm run verify`
|
||||
✔ Gate the emit path in `npm run verify` @done
|
||||
- `verify = check + test:unit`; `check:tsc` uses the root config (`noEmit: true`), so `tsconfig.build.json` is only exercised by `build`
|
||||
- a broken build config (bad `rootDir`, emit-option typo) passes `verify` and only fails in CI
|
||||
☐ Add `build` to `verify` (or to `check`)
|
||||
✔ Confirmed no change: `verify` is the local quick source-correctness check; the emit path is gated by CI's `build` job (`npm run build`), so adding `build` locally only adds inner-loop friction @done
|
||||
☐ Fix `.ts` extensions in emitted `.d.ts`
|
||||
- emitted JS rewrites `./pattern.ts` → `./pattern.js`, but `dist/*.d.ts` still imports `"./pattern.ts"` / `"./match.ts"`
|
||||
- resolves under TS7, but a portability risk for older resolvers/bundlers; `attw` does not catch it
|
||||
|
||||
Reference in new issue
Block a user