🔧 Resolve oxlint warnings; defer stylistic rules to oxfmt

This commit is contained in:
tmu committed 2026-09-03 21:33:04 +00:00
1 parent b3a4e14f45
commit 99fd85ca7e
5 files changed
+67 -35

No files matched your search

+8 -1
View File
@@ -13,7 +13,14 @@
"eslint/no-undefined": "off", "eslint/no-undefined": "off",
"eslint/sort-keys": "off", "eslint/sort-keys": "off",
"eslint/id-length": "off", "eslint/id-length": "off",
"import/no-named-export": "off" "import/no-named-export": "off",
"eslint/one-var": "off",
"import/group-exports": "off",
"import/exports-last": "off",
"eslint/sort-imports": "off",
"import/consistent-type-specifier-style": "off",
"unicorn/prefer-export-from": "off",
"typescript/method-signature-style": "off"
}, },
"env": { "env": {
"builtin": true, "builtin": true,
+16
View File
@@ -27,6 +27,22 @@ typescript-lib-starter-tiny => https://github.com/tmueller/typescript-lib-starte
- `eslint/sort-keys` — handler/case order is semantic, not alphabetical. - `eslint/sort-keys` — handler/case order is semantic, not alphabetical.
- `eslint/id-length` — `T`, `R`, `U`, `V` are standard TS generics. - `eslint/id-length` — `T`, `R`, `U`, `V` are standard TS generics.
- `import/no-named-export` — false positive on library entry re-exports. - `import/no-named-export` — false positive on library entry re-exports.
- Stylistic rules superseded by oxfmt (oxfmt is the canonical
formatter; these rules either conflict with its output or
duplicate features oxfmt already provides):
- `eslint/one-var` — oxfmt uses comma-joined `const`
declarations; oxlint wanted to split them.
- `import/group-exports` — oxfmt keeps separate `export`
statements as-is.
- `import/exports-last` — statement ordering is up to oxfmt.
- `eslint/sort-imports` — replaced by oxfmt's built-in
`sortImports` (enabled in `.oxfmtrc.json`).
- `import/consistent-type-specifier-style` — inline
`import { type X, Y }` is intentional for grouping.
- `unicorn/prefer-export-from` — conflicts with how the
barrel `src/index.ts` re-exports through `src/match.ts`.
- `typescript/method-signature-style` — method signatures
in `interface` are conventional TS ergonomics.
For `*.test.ts` files additionally: `no-unused-expressions` (for For `*.test.ts` files additionally: `no-unused-expressions` (for
`expectTypeOf(...)` calls), `no-empty-file` (we have a single import `expectTypeOf(...)` calls), `no-empty-file` (we have a single import
per test file in some cases), `import/no-nodejs-modules` (we use per test file in some cases), `import/no-nodejs-modules` (we use
+1 -1
View File
@@ -3,7 +3,7 @@ import { test } from "node:test";
import { expectTypeOf } from "expect-type"; import { expectTypeOf } from "expect-type";
import { match, P, type Matcher } from "./index.ts"; import { type Matcher, P, match } from "./index.ts";
test("match returns a builder", () => { test("match returns a builder", () => {
const builder = match("x"); const builder = match("x");
+1 -3
View File
@@ -1,8 +1,6 @@
import { P, type Matcher, type Pattern } from "./pattern.ts"; import { P, type Matcher, type Pattern } from "./pattern.ts";
type Cases<R> = ReadonlyArray< type Cases<R> = readonly (readonly [Matcher<unknown>, (value: unknown) => R])[];
readonly [Matcher<unknown>, (value: unknown) => R]
>;
interface MatchBuilder<T, R> { interface MatchBuilder<T, R> {
with<U extends T, V>( with<U extends T, V>(
+41 -30
View File
@@ -14,7 +14,6 @@ const literalMatcher = <
): Matcher<L> => ({ ): Matcher<L> => ({
matches: (candidate): candidate is L => candidate === value, matches: (candidate): candidate is L => candidate === value,
}); });
const typeMatcher = <T>( const typeMatcher = <T>(
type: type:
| "string" | "string"
@@ -27,54 +26,66 @@ const typeMatcher = <T>(
| "function", | "function",
): Matcher<T> => { ): Matcher<T> => {
const matches = (value: unknown): value is T => { const matches = (value: unknown): value is T => {
if (type === "undefined") return value === undefined; if (type === "undefined") {
if (type === "object") return value === undefined;
}
if (type === "object") {
return ( return (
(typeof value === "object" && value !== null) || (typeof value === "object" && value !== null) ||
typeof value === "function" typeof value === "function"
); );
}
return typeof value === type; return typeof value === type;
}; };
return { matches }; return { matches };
}; },
whenMatcher = <T>(
const whenMatcher = <T>(
predicate: (value: unknown) => value is T, predicate: (value: unknown) => value is T,
): Matcher<T> => ({ ): Matcher<T> => ({
matches: predicate, matches: predicate,
}); }),
whenMatcherAny = <T>(
const whenMatcherAny = <T>(
predicate: (value: unknown) => boolean, predicate: (value: unknown) => boolean,
): Matcher<T> => ({ ): Matcher<T> => ({
matches: (value: unknown): value is T => predicate(value), matches: (value: unknown): value is T => predicate(value),
}); }),
isNestedMatcher = (expected: unknown): expected is Matcher<unknown> =>
const structuralMatcher = <S extends object, T extends S>(
shape: S,
refine?: (value: S) => value is T,
): Matcher<T> => ({
matches: (value: unknown): value is T => {
if (typeof value !== "object" || value === null) return false;
const candidate = value as S;
for (const key of Object.keys(shape) as Array<keyof S>) {
if (!(key in candidate)) return false;
const expected = shape[key];
const actual = candidate[key];
if (
typeof expected === "object" && typeof expected === "object" &&
expected !== null && expected !== null &&
"matches" in expected "matches" in expected,
) { keysMatch = <S extends object>(shape: S, candidate: object): boolean => {
const nested = expected as unknown as Matcher<unknown>; for (const key of Object.keys(shape) as (keyof S)[]) {
if (!nested.matches(actual)) return false; if (!(key in candidate)) {
return false;
}
const expected = shape[key],
actual = candidate[key as keyof object];
if (isNestedMatcher(expected)) {
if (!expected.matches(actual)) {
return false;
}
} else if (actual !== expected) { } else if (actual !== expected) {
return false; return false;
} }
} }
return refine return true;
? refine(candidate) },
: (true as T extends S ? true : never); structuralMatcher = <S extends object, T extends S>(
shape: S,
refine?: (value: S) => value is T,
): Matcher<T> => ({
matches: (value: unknown): value is T => {
if (typeof value !== "object" || value === null) {
return false;
}
const candidate = value as S;
if (!keysMatch(shape, candidate)) {
return false;
}
if (refine && !refine(candidate)) {
return false;
}
return true;
}, },
}); });